[Webkit-unassigned] [Bug 108788] Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108788





--- Comment #5 from Timothy Loh <timloh at chromium.org>  2013-02-03 22:07:45 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 186300 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=186300&action=review
> > > 
> > > > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:87
> > > > -        new_date_line = new_entry.date_line()
> > > > -        old_date_line = old_entry.date_line()
> > > > -        if new_date_line != old_date_line:
> > > > -            final_entry = final_entry.replace(old_date_line, new_date_line)
> > > > +        final_entry = final_entry.replace(old_entry.date(), new_entry.date(), 1)
> > > 
> > > Why are we making this change? This patch needs per-function change log.
> > 
> > I'm not sure what you're asking here.
> 
> Exactly what I said. It's not obvious why this code change is necessary or desirable to fix the bug. This is why I'm suggesting to add per-function description in your change log so that others can understand why you're making each code change.

Ah, I was confused because the patch is about change logs so I was trying to interpret the sentence differently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.