[Webkit-unassigned] [Bug 108788] Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108788





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2013-02-03 21:50:13 PST ---
(From update of attachment 186300)
View in context: https://bugs.webkit.org/attachment.cgi?id=186300&action=review

> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:87
> -        new_date_line = new_entry.date_line()
> -        old_date_line = old_entry.date_line()
> -        if new_date_line != old_date_line:
> -            final_entry = final_entry.replace(old_date_line, new_date_line)
> +        final_entry = final_entry.replace(old_entry.date(), new_entry.date(), 1)

Why are we making this change? This patch needs per-function change log.

> Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:99
> +                      ((4, 0, 0, 0), (0, 0, 0, 0), (0, 0, 0, 0)),
> +                      ((5, 0, 0, 0), (0, 0, 0, 0), (1, 0, 0, 0)),
> +                      ((0, 0, 0, 0), (4, 0, 0, 0), (4, 0, 0, 0)),
> +                      ((1, 0, 0, 0), (4, 0, 0, 0), (5, 0, 0, 0)),

What the heck is this mysterious matrix?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.