[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 3 20:46:58 PST 2013


--- Comment #22 from Eric Seidel <eric at webkit.org>  2013-02-03 20:49:02 PST ---
(In reply to comment #21)
> (In reply to comment #19)
> > I see.  Well, updating the author is perhaps a bit extreme, and probably suggests we should ask for confirmation.  It's very easy to do, and we just need to respect the --non-interactive bit.
> What's do you think is the right thing to do here if we are in non-interactive mode? I think leaving the author unchanged seems a reasonable default, but I'm not sure it makes sense to call this with --non-interactive given the rest of the added behaviour in PrepareChangeLog (i.e. adding the changed list below).

I see, my point was more to notify you of the existance of the --non-interactive option, which all commands need to be aware to avoid trying to prompt a user when no user exists. :)

It's fine to remove the update-the-author functionality all together, it seems unlikely to be wanted very often.

The date and the changed files seem useful.

If folks don't want the list of changed files to include all files when there are more than N of them, then we should might code those heuristics into prepare-ChangeLog.

I guess I don't feel particularly strongly about any of this.  It seems that udating the list of changed files is a good default for webkit-patch.  If rniwa wants an option to be able to disable it, it is possible add an option.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list