[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 3 16:54:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=74358





--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org>  2013-02-03 16:56:18 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > That seems like a very conservative viewpoint.  I hear you saying "I don't trust this code, I want it off."  An alternate view might be "I don't want this code to break stuff, we better make sure it's correct/predictable/understandable" :)
> > 
> > I just don't want my change logs to get updated. There are times I apply someone's patch and upload that again so I need an option for the script not to mess with the change logs I already have.
> 
> I think the only thing this patch would make webkit-patch do that you won't want is replace the name/email with yours. The rest of the entry should stay the same unless the changed files/functions list or the bug description has changed. I didn't have your use case in mind here, so it doesn't quite do what you'd like. Both adding an option and not replacing the name/email should be straightforward changes, so I guess it's up to what you'd rather have.

Adding an option to not update the change log will be good. There are cases where you want to intentionally omit some files e.g. a patch to rebaseline thousands of expected results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list