[Webkit-unassigned] [Bug 81103] [Texmap] Implement BGRA swizzling detection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 2 00:14:26 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=81103


Igor Trindade Oliveira <igor.oliveira at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |igor.oliveira at webkit.org




--- Comment #10 from Igor Trindade Oliveira <igor.oliveira at webkit.org>  2013-02-02 00:16:28 PST ---
(In reply to comment #9)
> (From update of attachment 186178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186178&action=review
> 
> I remember this kind of patch had a tendency to break stuff :)
> Can someone validate it on more than one GLES2 hardware?

I tested in mesa3d llvmpipe, intel and mali t400.
The reverted implementation(changeset r110703) was slightly different. Basically it was just using BGRA in the external format, however in the GLESv2 case, when BGRA is used it also needs to be used in the internal texture format. 

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:591
> >  #if defined(TEXMAP_OPENGL_ES_2)
> > -    // FIXME: Implement reliable detection. See also https://bugs.webkit.org/show_bug.cgi?id=81103.
> > -    return false;
> > +    static bool supportsExternalTextureBGRA = context->getExtensions()->supports("GL_EXT_texture_format_BGRA8888");
> > +    return supportsExternalTextureBGRA;
> >  #else
> 
> I think we shoul switch here to isGLES2Compliant() instead of an #ifdef

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list