[Webkit-unassigned] [Bug 108667] [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 23:21:27 PST 2013


--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2013-02-01 23:23:29 PST ---
(From update of attachment 186088)
View in context: https://bugs.webkit.org/attachment.cgi?id=186088&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2401
> +bool WebViewImpl::isSelectionAnchorFirst() const

nit: isSelectionAnchorFirst is declared after selectionTextDirection.  please define functions in the same order that you declare them.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2403
> +    const Frame* frame = focusedWebCoreFrame();

I apologize for randomizing you further, but it seems like we might be
making a mistake by putting all of these selection APIs on WebWidget.
It seems like all of them act on the focused frame, so perhaps we
should really be putting selection methods on WebFrame instead.  Then,
if it is important for selectRange and selectionBounds to be in-sync,
it'll be more natural because they will be defined adjacent to one
another.  WDYT?

The thing to know about WebWidget is that it shouldn't know anything
about document or frame or any DOM concepts.  It is just a rendering
surface.  Originally, selection stuff ended up on WebWidget because
selection as a concept was just a rectangular region of the widget,
but maybe in hindsight that was a poor choice.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list