[Webkit-unassigned] [Bug 108541] [chromium-android] disable WebKit-side scrollbar rendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108541


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186196|review?                     |review-
               Flag|                            |




--- Comment #20 from James Robinson <jamesr at chromium.org>  2013-02-01 17:45:34 PST ---
(From update of attachment 186196)
View in context: https://bugs.webkit.org/attachment.cgi?id=186196&action=review

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:106
> +#if 0

just delete it, don't #if 0.  The code will live on in the revision tracking system when/if we want to revive it

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:148
> +    // FIXME: We're hardcoding scrollbars in the compositor until smoothiness issue getting solved.

smoothiness isn't a word, and this doesn't explain very well why we're doing nothing

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:151
> +    (void)context;
> +    (void)scrollbar;
> +    (void)rect;

The way in WebKit to deal with unused parameters is to not give them a name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.