[Webkit-unassigned] [Bug 108511] [Chromium] Spelling should ignore punctuation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 13:22:04 PST 2013


--- Comment #4 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-02-01 13:24:06 PST ---
(In reply to comment #2)
> (From update of attachment 186092 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186092&action=review
> > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:147
> > +// Returns true for whitespace and punctuation characters. Returns false for every other type of character.
> Remove this comment.

Removed. What are the guidelines for function comments?

> > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:150
> > +    return WTF::Unicode::isSeparatorSpace(c) || WTF::Unicode::isPunct(c);
> The old code did WTF::Unicode::direction(c) == WTF::Unicode::WhiteSpaceNeutral instead of WTF::Unicode::isSeparatorSpace(c).  Is this difference intentional?  Maybe we should #include <wtf/text/StringImpl.h> and use isSpaceOrNewline(c) || WTF::Unicode::isPunct(c) to be more like the old code?

The difference is not intentional. I switched to "isSpaceOrNewLine(c) || WTF::Unicode::isPunct(c)" as you suggested. I did not need to include StringImpl.h.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list