[Webkit-unassigned] [Bug 108459] [WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 11:29:03 PST 2013


--- Comment #3 from Jon Lee <jonlee at apple.com>  2013-02-01 11:31:05 PST ---
(From update of attachment 185746)
View in context: https://bugs.webkit.org/attachment.cgi?id=185746&action=review

> Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp:96
> +    if (!knownPermissions)

Wouldn't it be more appropriate to move this check before we clear out the permissions? If the client wishes to clear out the permissions, they should provide an empty dictionary instead.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list