[Webkit-unassigned] [Bug 108482] [WebCore][Notifications] Do not assume the page has a NotificationClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 11:22:21 PST 2013


--- Comment #5 from Jon Lee <jonlee at apple.com>  2013-02-01 11:24:23 PST ---
(From update of attachment 185782)
View in context: https://bugs.webkit.org/attachment.cgi?id=185782&action=review

Unofficial r=me.

> Source/WebCore/Modules/notifications/Notification.cpp:291
> +    if (client)

It would be better to define it in the if clause:

if (NotificationClient* client = ...)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list