[Webkit-unassigned] [Bug 108513] [Chromium] Replace correct misspelled range

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 10:54:55 PST 2013


--- Comment #3 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-02-01 10:56:57 PST ---
(In reply to comment #2)
> (From update of attachment 186074 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186074&action=review
> > Source/WebKit/chromium/src/WebFrameImpl.cpp:1319
> > -    frame()->editor()->replaceSelectionWithText(text, false, true);
> > +    frame()->editor()->replaceSelectionWithText(text, false, false);
> Why are you disabling smart replace?

If the user selects "wellcome_" together with underline, context clicks on the selection, and chooses the "welcome" suggestion, then smart replace will result in "welcome _". I think that might be OK behavior for replaceRange(), but not for replaceMisspelledRange(). This method should only replace the misspelling, not introduce extra spaces.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list