[Webkit-unassigned] [Bug 107840] Add smartInsertDeleteEnabled setting to WebCore::Page
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 1 09:57:18 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107840
Alexey Proskuryakov <ap at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #185048|review+, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #16 from Alexey Proskuryakov <ap at webkit.org> 2013-02-01 09:59:19 PST ---
(From update of attachment 185048)
Looks like this breaks initial value of the setting on Mac. We used to get it from "WebSmartInsertDeleteEnabled" user default in TextChecker::isSmartInsertDeleteEnabled(), and pass on process creation. Now, looks like every client has to call WKPreferencesSetSmartInsertDeleteEnabled().
Even worse, if WKPreferencesSetSmartInsertDeleteEnabled() gets called by the client, it is a no-op because of an early return:
void WebPageProxy::setSmartInsertDeleteEnabled(bool isSmartInsertDeleteEnabled)
{
if (m_isSmartInsertDeleteEnabled == isSmartInsertDeleteEnabled)
return;
So, this means that WKPreferencesSetSmartInsertDeleteEnabled(false) will have no effect on Mac if WebSmartInsertDeleteEnabled was set to NO.
r- because of this. Please feel free to reset the review flag if I misunderstood the code.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list