[Webkit-unassigned] [Bug 108088] [GStreamer] webkitwebsrc is exposed to application-side

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108088





--- Comment #7 from Philippe Normand <pnormand at igalia.com>  2013-02-01 09:14:22 PST ---
(In reply to comment #6)
> (From update of attachment 186028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186028&action=review
> 
> Looks good, but I think it could use a teensy bit of cleanup.
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:307
> > +void MediaPlayerPrivateGStreamer::setPlaybinURL(KURL url)
> 
> This should likely accept a const KURL& url to avoid a copy.
> 

I tried that when writing the initial patch but it didn't work out, will give it another chance.

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:335
> > +    // Clean out everything after file:// url path.
> > +    if (kurl.isLocalFile())
> > +        cleanUrl = cleanUrl.substring(0, kurl.pathEnd());
> 
> kurl.removeFragmentIdentifier() ? Probably better to put this into setPlaybinURL.

Well this code is shuffled around, I didn't mean to modify it but I guess I can give this a try :)

> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:579
> > +    ASSERT(url.protocol().substring(0, 7) == "webkit+");
> > +    url.setProtocol(url.protocol().substring(7));
> 
> You should probably make a getPlaybinURL method.
> 

Hum but the element has no access to the player.

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:598
> > -    static gchar* protocols[] = {(gchar*) "http", (gchar*) "https", 0 };
> > +    static gchar* protocols[] = {(gchar*) "webkit+http", (gchar*) "webkit+https", 0 };
> 
> So do we even support file URLs? I'm pretty sure you don't need these casts here.

file URLs are supported via the gst filesrc element.
IIRC the casts were needed when I did the initial port but I'll check it again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.