[Webkit-unassigned] [Bug 110779] WebKit API for enabling DOM logging for certain worlds

Thu Feb 28 18:52:28 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=110779

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190861|review?                     |review+
               Flag|                            |

--- Comment #27 from Adam Barth <abarth at webkit.org>  2013-02-28 18:54:51 PST ---
(From update of attachment 190861)
View in context: https://bugs.webkit.org/attachment.cgi?id=190861&action=review

This looks good.  There's just one nit about the include.  You've probably left the office for today, so I can try fixing that for you.

> Source/WebCore/bindings/v8/V8DOMActivityLogger.h:2
> + * Copyright (C) 2009 Google Inc. All rights reserved.

2009 -> 2013

> Source/WebKit/chromium/public/WebDOMActivityLogger.h:34
> +#include "../../../Platform/chromium/public/WebCanvas.h"

Why do we need this?  You should include WebCommon.h or something like that.

> Source/WebKit/chromium/src/WebDOMActivityLogger.cpp:53
> +private:

nit: We would normally put a blank line above this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.