[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com>  2013-02-28 05:33:12 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 190594 [details] [details])
> > Attachment 190594 [details] [details] did not pass mac-ews (mac):
> > Output: http://webkit-commit-queue.appspot.com/results/16772546
> > 
> > New failing tests:
> > editing/selection/doubleclick-beside-cr-span.html
> > editing/selection/doubleclick-whitespace.html
> 
> Did you forget to update these tests or DumpRenderTree?

Yes I forgot to change DumpRenderTree. I was just testing it in WK2.

Anway if I'm not wrong we have another prolbem as now tests are using internals.settings.setSelectTrailingWhitespaceEnabled.

This means that DRT code related to selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled is not used at all. As we're directly establishing the Page setting with internals.

So, in WK2 everything works due to my patches, however in WK1 the implementations of selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled are not using the new setting in Page yet, so that's the reason it's faling.

I guess that the solution should be:
1) Update WK1 code to use Page settings for selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled. I guess it should be done in a generic way and remove the specific  ports code related to selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled.
2) Remove code related to selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled from DRT.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.