[Webkit-unassigned] [Bug 110752] OpenCL implementation of FEImage SVG Filter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110752


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zherczeg at webkit.org




--- Comment #6 from Zoltan Herczeg <zherczeg at webkit.org>  2013-02-28 03:42:45 PST ---
(In reply to comment #5)
> (From update of attachment 190472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review
> 
> > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43
> > +    virtual bool platformApplyOpenCL();
> 
> This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL.

Good point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.