[Webkit-unassigned] [Bug 110939] Move markerTextForListItem from TestRunner to Internals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110939


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190627|review?                     |review-
               Flag|                            |




--- Comment #6 from Benjamin Poulain <benjamin at webkit.org>  2013-02-27 23:19:20 PST ---
(From update of attachment 190627)
View in context: https://bugs.webkit.org/attachment.cgi?id=190627&action=review

Looks great. Some comments still:

> Source/WebCore/ChangeLog:10
> +        as to make it more compatible with WK2

Missing period.

> Source/WebCore/testing/Internals.cpp:2013
> +String Internals::markerTextForListItem(Element* inputElement, ExceptionCode& ec)

In this case, valid input does not necessarily have to be an inputElement.
The argument name should be simply "element".

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:-138
> -{
> -    return toCopiedAPI(toImpl(frameRef)->markerText(element));
> -}

Thanks to this, you are making WebFrame::markerText useless. You should also clean that as part of the patch.

You can probably remove the include for RenderTreeAsText.h from WebFrame too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.