[Webkit-unassigned] [Bug 110778] Unlock partially decoded images after passing them to the ImageDecodingStore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110778





--- Comment #12 from Min Qin <qinmin at chromium.org>  2013-02-27 14:09:10 PST ---
(From update of attachment 190576)
View in context: https://bugs.webkit.org/attachment.cgi?id=190576&action=review

>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:157
>> +        // ImageDecodingStore should have deleted the decoder here.
> 
> Nit:  Is this something worth asserting in code of instead of in a comment, if possible?

hmm... probably this is not a good place to put the assertion. The cachedDecoder here is a dumb pointer. In order to check whether the decoder is deleted, we have to call lockCache() again. But that would break the lock/unlock situation.
An alternative is to put the assertion check into overwriteAndLockCache(). But the logic is already pretty straightforward inside that function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.