[Webkit-unassigned] [Bug 110703] Multi-line WebVTT cues are not positioned correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110703





--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2013-02-27 11:35:09 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Setting 'padding' on -webkit-media-text-track-display causes the problem I am seeing. Try adding this to a page with a <track>:
> 
> Thanks! Took me a while to understand this (fairly simple) problem - it lies in
> RenderTextTrackCue::isOutside(), because padding (or border, margin), increases
> both horizontal and vertical sizes of the cue (thus the width is 100% +
> padding pixels) and isOutside always returns true with such properties.
> 
> Due to the nature of the algorithm, if we allow padding and check only horizontal 
> fitting in the parent container, the cue will be shifted upwards with multiples of line height (depending on the exact extra size besides the cue lines).
> 
> Given that padding isn't really supported as VTT selector property, but we can
> set it via the pseudo-id, is the above described fix good enough? If there's a
> specific use-case for this, maybe a bug should be filed against the spec.

I think the only use case is for UA specific styling. I found this because I am using 'padding' to make the "window" around the cue text (-webkit-media-text-track-display ) bigger to match a user style. See CaptionUserPreferencesMac::captionsStyleSheetOverride. 

I agree that we don't need to pages overriding private styles, so I don't this we need to request a spec change, but if we can support this without an enormous amount of work it will allow us to be more flexible internally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.