[Webkit-unassigned] [Bug 110895] Focus ring for a child composited layer is incorrectly offset by parent layer's position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110895


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jchaffraix at webkit.org




--- Comment #5 from Julien Chaffraix <jchaffraix at webkit.org>  2013-02-27 08:51:02 PST ---
(In reply to comment #4)
> Seems like the root cause here is that outline:auto doesn't support transforms, right? 

AFAICT this is completely unrelated: the test case has 0 transforms and positioned offset are representable in our current system.

> I guess we'd need a way of taking the union of arbitrarily transformed quads -- is there code for that already?

Focus rings and outlines are represented as rectangles (IntRect / LayoutRect), not quads. You would need to update the code to support quads. See addFocusRingRect and paintOutline for details.

> As to clipping the outline to the overflow container, I think it would make sense to do that but maybe we should fix it in a different bug.

Outlines are specified in CSS 2.1 [1] and also CSS 3 UI [2]. We definitely want to follow what the specifications are saying, not what we believe 'outline' should be. If other browsers don't match our behavior, we should get the specification updated to match the consensus.

Relevant bits:

* "Outlines may be non-rectangular." (note that this is a MAY which makes our implementation using rects compliant)
* "By default, the outline is drawn starting just outside the border edge. However, it is possible to offset the outline and draw it beyond the border edge."
* "For example, if the element is broken across several lines, the outline should be an outline or minimum set of outlines that encloses all the element's boxes."

[1] http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines
[2] http://dev.w3.org/csswg/css3-ui/#outline-properties

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.