[Webkit-unassigned] [Bug 110968] Introduce new message sources for logging.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 27 05:26:49 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110968
--- Comment #4 from Mike West <mkwst at chromium.org> 2013-02-27 05:29:12 PST ---
(From update of attachment 190488)
View in context: https://bugs.webkit.org/attachment.cgi?id=190488&action=review
This is a great start, thank you! I like the direction... a few comments inline.
> Source/WebCore/Modules/webdatabase/DatabaseBase.cpp:49
> + m_scriptExecutionContext->addConsoleMessage(OfflineMessageSource, ErrorMessageLevel, message);
Why "Offline" here? I'd suggest something like "Storage", which would also allow us to change IDB messages.
> Source/WebCore/html/HTMLFormElement.cpp:264
> + document()->addConsoleMessage(JSMessageSource, ErrorMessageLevel, message);
Let's leave this as RenderingMessageSource, and probably change the message in a separate patch, as it's confusing. This error occurs when form validation would focus on a required element that, for whatever reason, isn't focusable. LayoutTests/fast/forms/interactive-validation-prevented.html has an example.
> Source/WebCore/html/HTMLIFrameElement.cpp:93
> + document()->addConsoleMessage(SecurityMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens);
This seems more like a rendering/parsing error than a security error. The sandbox isn't blocking anything, it's not being parsed correctly.
> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5314
> + document->addConsoleMessage(RenderingMessageSource, WarningMessageLevel, message);
It might make sense to give WebGL errors a source of their own, if we're going to be enabling filtering on them later.
> Source/WebCore/loader/MixedContentChecker.cpp:102
> // FIXME: Why does this message not have a source URL or a line number? webkit.org/b/97979
Since you're here, please kill this FIXME. We fixed it when adding stack traces to messages globally.
> Source/WebCore/svg/SVGDocumentExtensions.cpp:138
> + document->addConsoleMessage(RenderingMessageSource, level, message);
SVG might be another reason (alongside WebGL from above) to add a GraphicsMessageSource or something similar.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list