[Webkit-unassigned] [Bug 110939] Move markerTextForListItem from TestRunner to Internals
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 26 21:24:04 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110939
Benjamin Poulain <benjamin at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #190435|review? |review-
Flag| |
--- Comment #2 from Benjamin Poulain <benjamin at webkit.org> 2013-02-26 21:26:26 PST ---
(From update of attachment 190435)
View in context: https://bugs.webkit.org/attachment.cgi?id=190435&action=review
> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).
You should remove this line.
Your changelog should also have a short explanation for the change.
> Source/WebCore/WebCore.exp.in:163
> #if !defined(NDEBUG)
> __ZNK7WebCore14DocumentLoader9isLoadingEv
> #endif
> +__ZN7WebCore21markerTextForListItemEPNS_7ElementE
> __ZN7WebCore11JSDOMWindow6s_infoE
Symbols are sorted alphabetically. Why did you move this one?
> Source/WebCore/WebCore.order:514
> __ZN7WebCore11RenderThemeC2Ev
> +__ZN7WebCore21markerTextForListItemEPNS_7ElementE
> __ZN7WebCore13platformThemeEv
You should not change the order file yourself. It is generated for Safari.
> Source/WebCore/testing/Internals.h:306
> #endif
> +
> };
No need for the blank line.
> Source/WebCore/testing/Internals.idl:249
> + // Special Special DOM Functions from TestRunner
This comment does not add useful information for the reader, you can leave it out.
(by the way, WebKit comments must be sentences, starting with an uppercase letter, and finishing by a period)
> Source/WebKit/win/DOMCoreClasses.h:865
>
> - virtual HRESULT STDMETHODCALLTYPE markerTextForListItem(
> - /* [retval][out] */ BSTR* markerText);
> -
> virtual HRESULT STDMETHODCALLTYPE shadowPseudoId(
You cannot remove the Windows code.
We keep binary compatibility there, so removing a virtual function would break the virtual table of the class.
You can leave the WebKit/win part out.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list