[Webkit-unassigned] [Bug 110908] [GTK] Add libsecret package to jhbuild modules.

Tue Feb 26 14:16:15 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=110908

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190352|review?                     |review-
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-02-26 14:18:38 PST ---
(From update of attachment 190352)
View in context: https://bugs.webkit.org/attachment.cgi?id=190352&action=review

> Tools/gtk/jhbuild.modules:30
> +      <dep package="libsecret"/>

Did you take a look at the bug ( https://bugs.webkit.org/show_bug.cgi?id=109195 ) ? The purpose of the modules in jhbuild-optional is that they are optional. The modules installed by default are ones in which having the exact version is required for layout tests to pass. libsecret doesn't fall into this category and making it non-optional means that everyone has to build it, even when they don't need to.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.