[Webkit-unassigned] [Bug 110850] New: [GTK] No need to manually set PKG_CONFIG_PATH to system prefix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110850

           Summary: [GTK] No need to manually set PKG_CONFIG_PATH to
                    system prefix
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: csaavedra at igalia.com


Tools/gtk/jhbuildrc is manually adding system dirs to PKG_CONFIG_PATH:

  # Use system libraries while building.
  if use_lib64:
      _libdir = 'lib64'
  else:
      _libdir = 'lib'
  addpath('PKG_CONFIG_PATH', os.path.join(os.sep, 'usr', _libdir, 'pkgconfig'))
  addpath('PKG_CONFIG_PATH', os.path.join(os.sep, 'usr', 'share', 'pkgconfig'))

First of all, addpath() seems to be /prefixing/ the path to the env. variable. This might make sense in some cases, but it doesn't when your PKG_CONFIG_PATH is already set to something sensible (for instance, if you are building WebKit from GNOME's jhbuild shell, which sets up the PKG_CONFIG_PATH to the path where GNOME has been built).

Moreover, I think this is totally unnecessary. If partial_build is True (see https://mail.gnome.org/archives/desktop-devel-list/2011-July/msg00095.html) and PKG_CONFIG_PATH is empty, Config.setup_env() is already setting  it to, at least, use the system libraries. Therefore, I think that our jhbuildrc's addpath(PKG_CONFIG, ..) calls can be safely removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.