[Webkit-unassigned] [Bug 110717] [EFL] Consolidate defaults for feature flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110717





--- Comment #5 from Hugo Parente Lima <hugo.lima at openbossa.org>  2013-02-25 20:12:27 PST ---
(From update of attachment 190187)
View in context: https://bugs.webkit.org/attachment.cgi?id=190187&action=review

We may go further in the future and generate the @features dictionary based on values returned by the GCC preprocessor call, so this file would never be touched again.

> Tools/Scripts/build-webkit:93
> +    my $port = "EFL"."__";

There is a function called "cmakeBasedPortName()", may be better to use it if we think in a future where other ports will use this same mechanism.

IMO the "__" would go to the gcc command line string too, e.g. "-DBUILDING_${port}__".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.