[Webkit-unassigned] [Bug 110778] Unlock partially decoded images after passing them to the ImageDecodingStore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110778





--- Comment #2 from Hin-Chung Lam <hclam at google.com>  2013-02-25 12:03:41 PST ---
(From update of attachment 190101)
View in context: https://bugs.webkit.org/attachment.cgi?id=190101&action=review

Please move locking logic of ImageDecoder into ImageDecodingStore. ImageFrameGenerator shouldn't know about the underlying, it should only know that when an entry is locked, all locked resources are ready to be used.

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:145
> +        cachedDecoder->lockFrameBuffers();

You want to call this in ImageDecodingStore::lockCache() such that if lockFrameBuffers fails then a new decoder is created.

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:150
> +            cachedDecoder->unlockFrameBuffers();

Move this to ImageDecodingStore as well.

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:178
> +        decoder->unlockFrameBuffers();

Move this to ImageDecodingStore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.