[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109061





--- Comment #37 from Ruslan Abdikeev <aruslan at chromium.org>  2013-02-25 11:26:45 PST ---
(From update of attachment 189837)
View in context: https://bugs.webkit.org/attachment.cgi?id=189837&action=review

>> Source/WebCore/dom/Document.cpp:4466
>> +}
> 
> Where does the "Favicon" symbol come from and...

from WebCore::IconType enum (defined in Source/WebCore/dom/IconURL.h).

>> Source/WebCore/dom/Document.cpp:4468
>> +const Vector<IconURL>& Document::iconURLs(int iconTypes)
> 
> ...why is this not an enum?
> 
> This should be an enum

It's a bitmask of requested icon types (this matches IconController::urlsForTypes(int iconTypes) API).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.