[Webkit-unassigned] [Bug 110488] Work around a MSVC 2012 Update 1 bug causing a crash on x86

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 09:08:19 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=110488


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190063|review?                     |review+
               Flag|                            |




--- Comment #4 from Anders Carlsson <andersca at apple.com>  2013-02-25 09:10:42 PST ---
(From update of attachment 190063)
View in context: https://bugs.webkit.org/attachment.cgi?id=190063&action=review

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:73
> +            if (c1 != c2)

I think you should put a return false inside the #ifdef.

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:78
> +#endif

And then extend the ifdef below the return false; line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list