[Webkit-unassigned] [Bug 105126] Flexbox should ignore firstLetter pseudo element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105126





--- Comment #13 from Tony Chang <tony at chromium.org>  2013-02-22 14:43:04 PST ---
(In reply to comment #12)
> I moved this check in |findFirstLetterBlock|. RenderObject maybe apply first-letter from own style or inherited from parent. For example:
> <style>
>    div::first-letter {color: red}
> </style>
> <div>
>     <P>
> </div>
> "div" apply first-letter from own style while "p" inherited from "div".
> 

I think you're saying that it's the difference between ::first-letter being on #container or #flexbox in this example:
<div id=container>
<div id=flexbox style="display:-webkit-flex">
  <p>
</div>
</div>

If so, can you add some test cases that for ::first-letter on #container?

> In addition, the case marked as failling in Chromium TestExpectations apply first-letter psuedo-element but form controls render as flexbox, see
> This change make "color: green; font-size: 200%;" did not apply week control anymore.

I'm confused since I don't see green or large fonts in any of the checked in results:
http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png
http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png
http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png

Why doesn't first-letter show up in these results?  Are you seeing something different on your machine?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.