[Webkit-unassigned] [Bug 110524] Add a way to watch pages for elements matching a CSS selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110524





--- Comment #2 from Tony Chang <tony at chromium.org>  2013-02-22 14:04:18 PST ---
(From update of attachment 189626)
View in context: https://bugs.webkit.org/attachment.cgi?id=189626&action=review

High level questions:
- How hard do we want to work at hiding -webkit-callback from the web?  Should it show up in getComputedStyle or what should happen if the webpage decides to add it themselves (should that trigger the callback)?
- Should we fire a callback if a node that matches is set to display:none?  We don't construct a RenderObject or RenderStyle for nodes that are display:none.

There are a bunch of style violations.  You'll see them when running Tools/Scripts/check-webkit-style.

> Source/WebCore/dom/Document.cpp:2016
> +void Document::removeSelectorMatch(String selector) {

I think if there's a single match and if you move it in the document, we will destroy the RenderStyle and re-create it. That would fire spurious events (maybe that's OK?).

> Source/WebCore/rendering/style/RenderStyle.cpp:172
> +    if (!rareNonInheritedData->m_callbackSelectors.isEmpty()) {

I wonder if this extra check would show up in one of our existing page cyclers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.