[Webkit-unassigned] [Bug 110412] Building for WinCE (cmake) x86 targets fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110412


Mark Salisbury <mark.salisbury at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189559|0                           |1
        is obsolete|                            |
 Attachment #189773|                            |review?, commit-queue?
               Flag|                            |




--- Comment #7 from Mark Salisbury <mark.salisbury at hp.com>  2013-02-22 08:33:43 PST ---
Created an attachment (id=189773)
 --> (https://bugs.webkit.org/attachment.cgi?id=189773&action=review)
Proposed fix

Thanks for your review.

I simplified the description to one line: "Fix for building for x86 targets"

I think we don't want to change behavior in Platform.h.  I like the idea that if there aren't enough hints given from the compile command line about what your machine architecture is that you get an error that you need to deal with.

It's easy to focus on what this patch doesn't do, but here's what it does do:
1)  Addresses the bug I've filed (that you can't build the WinCE platform for x86)
2)  If you are building for ARM, if you don't do anything different current behavior will continue (WTF_ARM_TRADITIONAL will be defined by OptionsWinCE.cmake)
3)  If you are building for ARM, you have the option to specify your ARM architecture version and if you have THUMB2 support.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.