[Webkit-unassigned] [Bug 110375] Add client callbacks to notify of changes of associated from controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 17:53:33 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=110375





--- Comment #34 from WebKit Review Bot <webkit.review.bot at gmail.com>  2013-02-21 17:55:55 PST ---
Attachment 189650 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/FormAssociatedElement.cpp', u'Source/WebCore/html/FormAssociatedElement.h', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLFormElement.h', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/page/EditorClient.h', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/public/WebAutofillClient.h', u'Source/WebKit/chromium/src/EditorClientImpl.cpp', u'Source/WebKit/chromium/src/EditorClientImpl.h']" exit_code: 1
Source/WebCore/html/HTMLFormElement.cpp:146:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/html/HTMLFormElement.cpp:757:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/html/HTMLFormElement.cpp:758:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/html/HTMLFormElement.cpp:760:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/html/FormAssociatedElement.cpp:278:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/html/FormAssociatedElement.cpp:281:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/FormAssociatedElement.cpp:282:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 7 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list