[Webkit-unassigned] [Bug 109021] [css3-text] Support text-indent:each-line from css3-text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109021





--- Comment #5 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-02-21 16:20:37 PST ---
(From update of attachment 187774)
View in context: https://bugs.webkit.org/attachment.cgi?id=187774&action=review

>> Source/WebCore/css/CSSParser.cpp:2103
>> +        // [ <length> | <percentage> ] && [ hanging || each-line ]?
> 
> This line is wrong and it confused me. You are adding parsing for a subset of that and this should reflect what we *do* support. Also inherit is supported and should still be.

I have a plan to support "hanging" value. I'll do it after "each-line".

"hanging" is removed, "inherit" is added.
[ <length> | <percentage> ] && each-line? | inherit
is it right ?

>> Source/WebCore/css/CSSParser.cpp:9019
>> +    bool haveEachLine = false;
> 
> have (first it should be 'has') is a bit too generic here. Also I don't see why you seperate text-indent from each-line as each-line *is part of text-indent*. How about:
> 
> hasSeenFixedOrPercentage, hasParsedFixedPercentage, hasEncounteredFixedOrPercentage
> 
> (slight preference for hasParsedTextIndent)

I like hasParsedTextIndent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.