[Webkit-unassigned] [Bug 110375] Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 21 13:50:50 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110375
--- Comment #14 from Dane Walllinga <dgwallinga at chromium.org> 2013-02-21 13:53:11 PST ---
(In reply to comment #11)
> (From update of attachment 189372 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189372&action=review
>
> > Source/WebCore/html/FormAssociatedElement.cpp:166
> > + && element->document()->frame()->loader()->isComplete()) {
>
> frame() might return 0
>
> It's very unlikely that you want to call isComplete from this code.
Fixed, and instead conditioning on frame(). If frame() is present, will I need to worry about editor() or editor()->client() being 0? Couldn't get it to fail testing locally, but no doubt there are certain edge cases I didn't hit.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list