[Webkit-unassigned] [Bug 110412] Building for WinCE (cmake) x86 targets fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110412


Mark Salisbury <mark.salisbury at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189429|0                           |1
        is obsolete|                            |
 Attachment #189429|review?, commit-queue?      |
               Flag|                            |
 Attachment #189559|                            |review?, commit-queue?
               Flag|                            |




--- Comment #5 from Mark Salisbury <mark.salisbury at hp.com>  2013-02-21 11:07:20 PST ---
Created an attachment (id=189559)
 --> (https://bugs.webkit.org/attachment.cgi?id=189559&action=review)
Proposed fix

Unfortunately, none of the ARM architecture defines besides just "_ARM_" and "ARM" are set (this is either a problem with my platform SDK or with CMake), so it is necessary to define either WTF_CPU_ARM_THUMB2 or WTF_CPU_ARM_TRADITIONAL in OptionsWinCE.cmake when building for ARM.  I'm not the only one with this issue (as WTF_CPU_ARM_TRADITIONAL is defined now in OptionsWinCE.cmake).

With this patch, you can build for x86 and you can build for ARM.  If you choose, when you run CMake you can specify what your ARM architecture version is and if you have THUMB2 support.  I tried both of these, since I'm actually targeting a Cortex A8 CPU (ARM architecture v7).  When I did this I discovered some other issues that will need to be addressed later to enable ARM v7 architecture on WinCE.  If you don't specify the ARM architecture version or THUMB2 support, then you get WTF_CPU_ARM_TRADITIONAL defined (same as we have now) which does build successfully.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.