[Webkit-unassigned] [Bug 110304] Add setting to add viewport tag to image documents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110304





--- Comment #6 from Tien-Ren Chen <trchen at chromium.org>  2013-02-21 00:19:53 PST ---
(In reply to comment #4)
> (From update of attachment 189242 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189242&action=review
> 
> What happens when the image is very large?  I expect it will look cut off.  It would be better to have an exact fit in that case, especially given that deviceScaleFactor means we can usually have a pageScaleFactor of 0.5 to get the true resolution of the image.

Yea I'm not sure what behavior gives best user experience. Let's have some discussion with UX folks when we have time.

(In reply to comment #5)
> (From update of attachment 189242 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189242&action=review
> 
> > Source/WebCore/html/ImageDocument.cpp:204
> > +    if (frame()->page()->settings()->overrideViewportForImage()) {
> 
> Are frame and page always non-zero here?

I think so. The same function calls shouldShrinkToFit() below, which accesses frame()->page()->settings() too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.