[Webkit-unassigned] [Bug 110415] Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110415


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189425|review?                     |review-
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-02-20 18:09:20 PST ---
(From update of attachment 189425)
View in context: https://bugs.webkit.org/attachment.cgi?id=189425&action=review

Let's try some new names.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:211
> +    unsigned _windowChangesDeferredCount;

viewInWindowDeferredCount?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1907
> +        if ([self windowChangesDeferred]) {
> +            _data->_page->viewStateDidChange(WebPageProxy::ViewIsVisible);
> +            _data->_windowChangeWasDeferred = YES;

The naming makes this confusing. It's easy to think that -windowChangesDeferred would return data->_windowChangeWasDeferred.

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:60
> +- (BOOL)windowChangesDeferred;

How about:

-beginDeferringViewInWindowChanges
-endDeferringViewInWindowChanges
-shouldDeferViewInWindowChanges

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.