[Webkit-unassigned] [Bug 105486] Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105486





--- Comment #51 from James Robinson <jamesr at chromium.org>  2013-02-20 17:59:55 PST ---
(From update of attachment 189224)
View in context: https://bugs.webkit.org/attachment.cgi?id=189224&action=review

> Source/WebCore/page/FrameView.cpp:2040
> +    LayoutSize viewportConstrainedVisibleContentSize = viewportConstrainedVisibleContentRect().size();
> +    viewportConstrainedVisibleContentSize.scale(1 / frame()->frameScaleFactor());
> +    if (fixedElementsLayoutRelativeToFrame() && m_lastSeenViewportConstrainedVisibleContentsSize != viewportConstrainedVisibleContentSize)

nuke the guards

> Source/WebCore/page/FrameView.cpp:2042
> +    m_lastSeenViewportConstrainedVisibleContentsSize = viewportConstrainedVisibleContentSize;

don't need this

> Source/WebCore/page/FrameView.cpp:2882
> +void FrameView::visibleContentScaleFactorDidChange()
> +{
> +    if (!m_frame || !m_frame->page())
> +        return;
> +
> +    if (!m_frame->settings()->applyPageScaleFactorInCompositor() || m_frame != m_frame->page()->mainFrame())
> +        return;
> +
> +    visibleContentsResized();

nuke this

> Source/WebCore/page/FrameView.h:186
> +    void visibleContentScaleFactorDidChange();

don't need this

> Source/WebCore/page/FrameView.h:592
> +    // For fixedElementsLayoutRelativeToFrame() == true.
> +    // We don't want unnecessary layout when visible contents size didn't actually change.
> +    LayoutSize m_lastSeenViewportConstrainedVisibleContentsSize;

don't need this

> Source/WebCore/page/Page.cpp:751
> +    view->visibleContentScaleFactorDidChange();

just view->visibleContentsResized()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.