[Webkit-unassigned] [Bug 110413] New: [v8] opaqueRootForGC should allow adding multiple roots for a single wrapper

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110413

           Summary: [v8] opaqueRootForGC should allow adding multiple
                    roots for a single wrapper
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: adamk at chromium.org
                CC: abarth at webkit.org, haraken at chromium.org


There's one instance of this so far, which is that MutationObservers need to make each of their registered nodes an opaque root (see V8GCController.cpp).

So first, is this indeed worth doing, as the FIXME I added claims? Or is this really the only case that needs this feature?

And if it is worthwhile, I can think of two possible approaches:

1) Pass some sort of slimmed-down WrapperGrouper interface into opaqueRootForGC() and let each class add one or more opaque roots. The main downside here is that it pushes complexity down into WrapperTypeInfo and the wrapper classes.

2) Return a Vector<void*, 1> (or pass one by reference). This keeps the leaf classes a little simpler, at the possible cost of a few more allocations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.