[Webkit-unassigned] [Bug 110391] New: Document::parsing() and Document::setParsing() are non-sense and should be removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110391

           Summary: Document::parsing() and Document::setParsing() are
                    non-sense and should be removed
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, japhet at chromium.org,
                    tonyg at chromium.org


Document::parsing() and Document::setParsing() are non-sense and should be removed

void Document::implicitOpen()
{
....
    m_parser = createParser();
    setParsing(true);
    setReadyState(Loading);
}

void Document::finishedParsing()
{
    ASSERT(!scriptableDocumentParser() || !m_parser->isParsing());
    ASSERT(!scriptableDocumentParser() || m_readyState != Loading);
    setParsing(false);
...

void FrameLoader::stopLoading(UnloadEventPolicy unloadEventPolicy)
{
...
    if (m_frame->document() && m_frame->document()->parsing()) {
        finishedParsing();
        m_frame->document()->setParsing(false);
    }


It's read in various places, and set some by the XML parsers.

It appears to be part of the loader state machine, but doesn't ever consult the DocumentParser as to what it's actually doing, so is undoubtably confused. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.