[Webkit-unassigned] [Bug 105486] Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105486





--- Comment #48 from James Robinson <jamesr at chromium.org>  2013-02-20 00:44:34 PST ---
(In reply to comment #43)
> (In reply to comment #42)
> > (From update of attachment 189217 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=189217&action=review
> > 
> > > Source/WebCore/page/Page.cpp:751
> > > +    view->visibleContentScaleFactorDidChange();
> > 
> > this line will only be reached if the page scale actually changed (see line 726), so why do another round of checks on the visible viewport size? when will that stay the same?
> 
> FrameView::visibleContentsResized() gets called a lot. Scrolling without changing scrollbar visibility? Still get called. Changing overlay scrollbar visibility? Still get called.
> 
> I would say we'd better apply the same guard on the whole function, but I don't know what are the possible side effects.

I don't really understand this comment.  It seems to be a general statement and not an answer to my question re page scale changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.