[Webkit-unassigned] [Bug 110249] New: Style checker incorrectly flagging a patch for mimetype errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 12:20:01 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=110249

           Summary: Style checker incorrectly flagging a patch for
                    mimetype errors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pdr at google.com
                CC: abarth at webkit.org, alancutter at chromium.org


The style checker is complaining about a patch on the following bug ("Rebased patch (3)"): https://bugs.webkit.org/show_bug.cgi?id=99984. The queue results (http://queues.webkit.org/results/16615901) say:

Failed to run "['/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-feeder-01', 'check-style-local', '--non-interactive', '--quiet']" exit_code: 2 cwd: /mnt/git/webkit-style-queue

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.png', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.txt', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all.svg', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all-expected.png', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all-expected.txt', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all.svg', u'Source/WebCore/ChangeLog', u'Source/WebCore/svg/SVGPreserveAspectRatio.cpp']" exit_code: 1
LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 13 files


This patch passes the style checker locally and I verified the property is set in svn, and in the patchfile itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list