[Webkit-unassigned] [Bug 110165] New: Merge handleSpecialChild into layoutBlockChildren

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 16:22:11 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=110165

           Summary: Merge handleSpecialChild into layoutBlockChildren
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: eric at webkit.org, hyatt at apple.com, robert at webkit.org


The name handleSpecialChild is extremely vague and doesn't communicate at all what it's handling and what "special" children are.

Since this function is only called by layoutBlockChildren, we can merge into layoutBlockChildren altogether.
In fact, handlePositionedChild and handleFloatingChild can also be merged into layoutBlockChildren.

That allows us to remove outdated comment in layoutBlockChildren that says:
// Handle the four types of special elements first.  These include positioned content, floating content, compacts and
// run-ins.  When we encounter these four types of objects, we don't actually lay them out as normal flow blocks.
which at this point is only half true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list