[Webkit-unassigned] [Bug 63516] Some canvas arc tests fail because the arc implementaion does not match the HTML5 canvas specification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63516





--- Comment #14 from Dirk Schulze <krit at webkit.org>  2013-02-16 00:22:13 PST ---
(From update of attachment 99691)
View in context: https://bugs.webkit.org/attachment.cgi?id=99691&action=review

> LayoutTests/ChangeLog:16
> +        the arc can never cover an angle greater than 2π radians. If the two

The pi signe looks strange. Just use pi.

> LayoutTests/ChangeLog:18
> +        points are the same, or if the radius is zero, then the arc is defined
> +        as being of zero length in both directions."

I don't like this text at all. It basically says: You can not draw a full circle.

> LayoutTests/ChangeLog:29
> +        Fix 9 canvas layout tests because those are failed after this patch. The layout
> +        tests use arc api like this, "ctx.arc(x, y, r, 0, Math.PI*2, true);".
> +        Above code should not draw circle to conform Canvas spec. Above code draw
> +        nothing. Above code should be changed to following code to draw circle.
> +            ctx.arc(x, y, r, 0, Math.PI*2, false);
> +            ctx.arc(x, y, r, Math.PI*2, 0, true);

I don't get your point. The necessary quote is 

"If the two points are the same,..., then the arc is defined as being of zero length in both directions."

So it doesn't draw anything, independent of clockwise or anti-clockwise, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.