[Webkit-unassigned] [Bug 34804] Some WTF headers fail to compile under VS2008 and newer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34804


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188575|review?                     |review-
               Flag|                            |




--- Comment #12 from Darin Adler <darin at apple.com>  2013-02-15 09:44:56 PST ---
(From update of attachment 188575)
View in context: https://bugs.webkit.org/attachment.cgi?id=188575&action=review

Patch is incorrect, at least for non-Microsoft compilers, has no change log, and also does not apply successfully.

> JavaScriptCore/heap/PassWeak.h:162
> -template<typename T> PassWeak<T> inline adoptWeak(WeakImpl* impl)
> +template<typename T> PassWeak<T> adoptWeak(WeakImpl* impl)

This is an unacceptable change for other compilers. The inline keyword tells the compiler to inline this function. Not sure why Microsoft’s compiler is having a problem with this, but please don’t punish all others for this mistake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.