[Webkit-unassigned] [Bug 34804] Some WTF headers fail to compile under VS2008 and newer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34804


Victor Bonnedun <victor.bonnedun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.bonnedun at gmail.com




--- Comment #10 from Victor Bonnedun <victor.bonnedun at gmail.com>  2013-02-15 07:09:08 PST ---
(In reply to comment #8)
> (In reply to comment #4)
> > I do not think you should disable this warning in common.vsprops because accordingly to Microsoft: "The compiler issues warning C4396 and IGNORES THE INLINE SPECIFIER." http://msdn.microsoft.com/en-us/library/bb384968.aspx
> > I am pretty sure that VS2005 compiler as well as many others also ignored inline specifier in that particular case, but without warning. :)
> 
> I think the way to make a decision here is roughly:
> 
> * Does any compiler honor the inline specifier on adoptRef?
>    * No: we should just remove it
>    * Yes:
>       * Does removing the inline specifier have any negative effects for those compilers which honor it?
>          * No: we should just remove it
>          * Yes: we should ignore the warning

Hello,

Any news about this problem ?

I am currently trying to compile webkit using VS2008 and I encountered this issue.
As mentionned in Bug 34828, there are 3 inline statements that should be removed in order to compile under VS2008 (I submitted a patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.