[Webkit-unassigned] [Bug 97324] [GTK] Add support for Page Visibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97324





--- Comment #14 from Anton Obzhirov <a.obzhirov at samsung.com>  2013-02-14 08:47:10 PST ---
(From update of attachment 187854)
View in context: https://bugs.webkit.org/attachment.cgi?id=187854&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2947
>> + * For more information about Page Visibility see http://www.w3.org/TR/2011/WD-page-visibility-20110602/.
> 
> For the sake of readability, do you mind making these lines about as long as the other documentation? "Java Script" should be "JavaScript". :)

No problem :)

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:167
>> + * Enum values to specify the different visibility states for a #WebKitWebView
> 
> Perhaps make this a bit terser? I'm thinking something like "The page is at least partially visible and the hidden attribute is set to false." and then "The page is not visible at all on the screen."

ok

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:171
>> +{
> 
> The curly brace here should be on the same line as the enum.

ok

>> Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h:49
>> +    void showInWindow(GtkWindowType = GTK_WINDOW_POPUP);
> 
> You aren't using the "mapped" state of the widget here, so why do you actually need to show the window?

To test normal use case (page visibility is changed indirectly via widget API) I want to show the window. To verify that page visibility is updated I need to wait for JavaScript callback and then check the page visibility. I am not sure which event will happen first - 'window mapped' or 'visibility changed', so I ignore first one and wait for the visibility change instead.

>> Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp:966
>> +    DumpRenderTreeSupportGtk::resetPageVisibility(webView);
> 
> Instead of exposing more API, why not just call  DumpRenderTreeSupportGtk::setPageVisibility(webView, WebCore::PageVisibilityStateVisible);

will have to add extra parameter in DumpRenderTreeSupportGtk::setPageVisibility(webView, WebCore::PageVisibilityStateVisible,
 bool)
 ^^^^
but yes can do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.