[Webkit-unassigned] [Bug 109811] New: Web Inspector: don't create static local string for program literal in InspectorTimelineAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109811

           Summary: Web Inspector: don't create static local string for
                    program literal in InspectorTimelineAgent
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yurys at chromium.org
                CC: keishi at webkit.org, pmuellr at yahoo.com,
                    pfeldman at chromium.org, yurys at chromium.org,
                    apavlov at chromium.org, loislo at chromium.org,
                    vsevik at chromium.org,
                    web-inspector-bugs at googlegroups.com


InspectorTimelineAgent::innerAddRecordToTimeline contains the following declaration
 DEFINE_STATIC_LOCAL(String, program, (TimelineRecordType::Program));

Since there may be timeline agent on worker thread there is a risk of leaking the string in case of concurrent initialization. I think it was introduced to avoid creating wrappers each time for TimelineRecordType::Program C-string but there is overloaded operator==(cons String&, const char*) so the performance shouldn't suffer if compare type string with the constant directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.