[Webkit-unassigned] [Bug 108690] Add ImageFrameCache to facilitate access to ImageFrames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108690





--- Comment #26 from Min Qin <qinmin at chromium.org>  2013-02-13 20:08:25 PST ---
I am fine with that. We already got several blocks of USE(SKIA) in imageDecoder.h, so probably just put lock()/unlock() in the same block as others. 
resizeFrameCache() can be used by all platforms. We just need to put the default implementation in !USE(SKIA) block in ImageDecoder.cpp and our own in ImageDecoderSkia.cpp.

(In reply to comment #25)
> (In reply to comment #24)
> > (In reply to comment #23)
> > > I think our options are:
> > > 
> > > 1. Add more #if USE(SKIA) in ImageDecoder.h and implement in ImageDecoderSkia.cpp Which I do no prefer.
> > 
> > I don't think it would be that bad.  You'd be adding two more function declarations to an existing #if USE(SKIA) block, and two more implementations to ImageDecoderSkia.cpp.
> 
> Okay I have no objection to this if you like this better.
> 
> Which means:
> 
> 1. ImageDecoder should have a resizeFrameCache method. That we can implement a platform specific version to assign allocator in ImageDecoderSkia.cpp.
> 
> 2. Have lock / unlock in ImageDecoder under #if USE(SKIA).
> 
> Min do you think this is reasonable? Sorry for making you do all this work..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.