[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor CoordinatedSurface to provide beginPaint and endPaint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 17:24:08 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108899





--- Comment #13 from Benjamin Poulain <benjamin at webkit.org>  2013-02-13 17:26:23 PST ---
> GraphicsContext is owned by the CoordinatedSurface because there are two ways to create GraphicsContext in CoordinatedSurface, via GraphicsSurface and ShareableBitmap. Both GraphicsSurface and ShareableBitmap provide PassOwnPtr<GraphicsContext> and CoordinatedSurface manages lifecycle of that GraphicsContext by providing beginPaint and endPaint.
> 
> This refactoring is necessary because in Threaded Coordinated Graphics, CoordinatedSurface will provide GraphicsContext using either GraphicsSurface or ImageBuffer. Since ImageBuffer owns GraphicsContext itself, CoordinatedSurface cannot pass PassOwnPtr<GraphicsContext>. Instead, it should pass GraphicsContext* so that CoordinatedImageBacking and UpdateAtlas can use the GraphicsContext.

Let's ask things differently, why doesn't GraphicsSurface have the responsibility for its GraphicsContext in the first place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list